Skip to content

Create scijava-table component #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imagejan opened this issue Jan 18, 2018 · 3 comments
Closed

Create scijava-table component #314

imagejan opened this issue Jan 18, 2018 · 3 comments
Assignees
Milestone

Comments

@imagejan
Copy link
Member

As part of SciJava 3, we should migrate the net.imagej.table package from imagej-common to a new scijava-table component.

See also scijava/batch-processor#8 (comment).

@imagejan imagejan added this to the 3.0.0 milestone Jan 18, 2018
@imagejan
Copy link
Member Author

The following components inside the net.imagej.table package currently have net.imagej dependencies outside the table package:

  • ResultsTable (defines an ImgPlus img() method)
  • DefaultResultsTable
  • ResultsImg
  • DefaultResultsTableTest

The DefaultTableDisplay and TableLoader classes depend on ResultsTable, so in order to move net.imagej.table to org.scijava.table, it would be nice to separate the img() method into an ImageJ-specific interface and keep ResultsTable without img().

ResultsImg would then be the only class remaining in imagej-common.

Is there any code that actively uses ResultsTable.img()? Can we change this?

@stelfrich
Copy link
Member

Then we should probably also migrate imagej/imagej-plugins-io-table to scijava/scijava-plugins-io-table.

@imagejan
Copy link
Member Author

Addressed by scijava/scijava-table#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants