Python functions in a script do not inherit enclosing scope

[ctrueden]

As noted by @ian-coccimiglio here, scripts with functions do not inherit imported modules, nor other globals.

This script fails:

import numpy

def version():
    return numpy.__version__

print(version())

Whereas this script works:

import numpy

def version():
    global numpy
    return numpy.__version__

print(version())

Interestingly, SciJava #@ variables injected into the bindings are put into locals() but not globals(), which means they are inaccessible to functions even when the global keyword is used:

#@ ImageJ ij
print(ij)
print(f"-- Globals? {'ij' in globals()}")
print(f"-- Locals? {'ij' in locals()}")
print(f"-- Dir? {'ij' in dir()}")

yields:

plugin:net.imagej.ImageJ
-- Globals? False
-- Locals? True
-- Dir? True

So there are maybe two different bugs going on here?

[imagesc-bot]

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/running-napari-alongside-fiji/109949/5

[karlduderstadt]

So I guess you are saying script_locals should instead by called script_globals here and in the exec function call it should be the globals input and the locals input should be empty?

https://github.com/scijava/scyjava/blob/d1583a1bb4b1fc795829bdb877eb2e8ba46af49c/src/scyjava/_script.py#L68-L103

The fact that imported modules are not accessible in methods is more confusing to me. I thought those import statements are included directly in the script passed to the exec function. 🤔

[ctrueden]

@karlduderstadt Yeah, I'm not sure yet what the best solution is. Just wanted to get the issue filed. If anyone wants to chime in about best practices here, it would be helpful. Otherwise, I'll work on this issue as part of rolling out this component to Fiji's new Java-21-based update site, hopefully some time next month.

[ian-coccimiglio]

So I guess you are saying script_locals should instead by called script_globals here and in the exec function call it should be the globals input and the locals input should be empty?

https://github.com/scijava/scyjava/blob/d1583a1bb4b1fc795829bdb877eb2e8ba46af49c/src/scyjava/_script.py#L68-L103

The fact that imported modules are not accessible in methods is more confusing to me. I thought those import statements are included directly in the script passed to the exec function. 🤔

Wanted to mention this in relation to why the imported modules are not passed to exec().

#Appose > Getting Started with Fiji-Appose @ 💬