Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building wheel from source introduces a circular dependency on cmake #506

Closed
dhellmann opened this issue Jun 14, 2024 · 2 comments
Closed

Comments

@dhellmann
Copy link

When I run pip wheel to create a wheel from the source distribution, pip wants to install a cmake package.

This was previously reported as #479 with an earlier fix in #480 based on the change in scikit-build-core at scikit-build/scikit-build-core@c67339b

The scikit-build-core code at https://github.com/scikit-build/scikit-build-core/blob/main/src/scikit_build_core/build/__init__.py#L126 looks for requires.settings.wheel.cmake which translates in the pyproject.toml file to needing

[tool.scikit-build]
wheel.cmake=false

To ensure cmake is not needed for building sdists, we should also add

[tool.scikit-build]
sdist.cmake=false

The previous change added

[tool.scikit-build]
cmake.version = ""  # We are cmake, so don't request cmake

but that location isn't being checked.

@henryiii
Copy link
Contributor

pip wants to install a cmake package

This should not happen if you have an empty cmake.version. That sounds like a potential bug? We do need cmake (CLI) on the PATH.

@dhellmann
Copy link
Author

OK, I can't find why, but I get different results for python 3.10 and 3.11, even for the same versions of pyproject_hooks and scikit-build-core. I think this is an issue in some other part of the tool chain, so I'll close this out and look for another way to work around it.

Sorry for the noise, and thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants