-
Notifications
You must be signed in to change notification settings - Fork 65
Install does not preserve symlink #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Symlinks are not supported by CPython’s standard library in zipfile. Wheels are just zip files. |
Hmm, bummer. Zip files themselves support symlinks though right? Is python/cpython#107845 supposed to fix that, or that is just for the build and not for the archiving? |
That’s tarfile (and security related). The issue is with zipfile, tarfile does support them. There’s a 10+ year old bug report about it somewhere. Now that windows simlink support is a lot better, I think it should be revisited. But it hasn’t afaik. I’ve also seen a third-party library that support symlinks in zipfiles. But pip doesn’t use it. pep 660 mentions this bug. (and yes, zip itself supports symlinks) |
There are older issues, but this seems to be the tracking issue: python/cpython#82102 Looks like it was on hold until security issues could be worked out with tar file. But I think those were worked out. |
Should be supported automatically when that issue is resolved right? |
Uh oh!
There was an error while loading. Please reload this page.
Just quickly writing the issue before looking more carefully. Basically I've noticed that at least on
muslinux
, the symlinks are not maintained and instead the linked files are copiedThe text was updated successfully, but these errors were encountered: