Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipfile.BadZipFile: Bad magic number for file header #696

Closed
LecrisUT opened this issue Apr 11, 2024 · 3 comments
Closed

zipfile.BadZipFile: Bad magic number for file header #696

LecrisUT opened this issue Apr 11, 2024 · 3 comments

Comments

@LecrisUT
Copy link
Collaborator

This is about an issue on the release of spglib. Basically it concerns the artifact of scitkit-build-core + cibuildwheel: https://github.com/spglib/spglib/actions/runs/8647336672/job/23714377810

Weird thing is dist/spglib-2.4.0-cp310-cp310-macosx_10_9_x86_64.whl works well, but dist/spglib-2.4.0-cp311-cp311-macosx_10_9_x86_64.whl fails with the issue in the title.

@henryiii
Copy link
Collaborator

This is actions/download-artifact#298

You must have unique names in the artifacts. Make sure you are not producing the same wheel twice.

@LecrisUT
Copy link
Collaborator Author

Oh indeed I had 2 runner macos-13 and macos-11. Did not expect them to just merge the files together. Why is that not producing errors?

@henryiii
Copy link
Collaborator

There's a bug in that action where instead of producing an error (which is what I'd prefer) or picking the first or last matching file, download-artifact just garbles the bits. This most notably shows up on file formats that have some error checking (like zip).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants