Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters should not be assigned in place #177

Closed
jpivarski opened this issue Mar 18, 2020 · 1 comment
Closed

Parameters should not be assigned in place #177

jpivarski opened this issue Mar 18, 2020 · 1 comment
Labels
feature New feature or request

Comments

@jpivarski
Copy link
Member

Array nodes should become fully immutable. Removing the setidentities and assigning them only in the constructor would involve fixing a few tests.

Also, there's no high-level interface to setting parameters: it's all done through a back door (.layout) right now. Parameters are more for framework developers than data analysts, though, so maybe that's appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant