Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate lower bounds of dependencies in CI #1350

Closed
matthewfeickert opened this issue Mar 5, 2021 · 2 comments · Fixed by #1355
Closed

Validate lower bounds of dependencies in CI #1350

matthewfeickert opened this issue Mar 5, 2021 · 2 comments · Fixed by #1355
Assignees
@matthewfeickert
Labels
CI CI systems, GitHub Actions good first issue Good for newcomers tests pytest

Comments

@matthewfeickert
Copy link
Member

Description

To ensure that the lower bound of all dependencies are still sufficient for the API used, add a test that installs from a lower-bound-requirements.txt that might look something like

# core
scipy==1.4.0
click==7.0.0
tqdm==4.56.0
jsonschema==3.2.0
jsonpatch==1.23.0
pyyaml==5.1.0
# xmlio
uproot3==3.14.0
uproot==4.0.0
# minuit
iminuit==2.1.0
# ...

and then run the test suite.
@matthewfeickert matthewfeickert added tests pytest CI CI systems, GitHub Actions labels Mar 5, 2021
@matthewfeickert matthewfeickert added the good first issue Good for newcomers label Mar 5, 2021
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Mar 5, 2021 •
edited
Loading

Trying to go through this I'm reliving the frustrations that TensorFlow and TensorFlow Probability have bought over the last year. A short list of the pain:

@matthewfeickert
Copy link
Member Author

jax and jaxlib lower bounds need to be updated to

jax==0.2.8
jaxlib==0.1.58

given jax-ml/jax#5374

@matthewfeickert matthewfeickert mentioned this issue Mar 7, 2021
Merged
4 tasks
@matthewfeickert matthewfeickert self-assigned this Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewfeickert matthewfeickert

Labels
CI CI systems, GitHub Actions good first issue Good for newcomers tests pytest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Test lower bounds of dependencies scikit-hep/pyhf
1 participant
@matthewfeickert