Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significance and discovery test statistic #1587

Open
1 task done
kratsg opened this issue Sep 3, 2021 · 4 comments
Open
1 task done

Significance and discovery test statistic #1587

kratsg opened this issue Sep 3, 2021 · 4 comments
Labels
docs Documentation related feat/enhancement New feature or request

Comments

@kratsg
Copy link
Contributor

kratsg commented Sep 3, 2021

Summary

Create a learn notebook that demonstrates the s/sqrt(b) approximation using the q0 test statistic like so:

>>> import pyhf
>>> 
>>> model = pyhf.simplemodels.uncorrelated_background([25], [2500], [2.5])
>>> pyhf.infer.test_statistics.q0(
...     0.0,
...     [2525] + model.config.auxdata,
...     model,
...     model.config.suggested_init(),
...     model.config.suggested_bounds(),
...     model.config.suggested_fixed(),
... )
array(0.24854737)
>>> _**0.5
0.49854525422391327
>>> 25 / (2500**0.5)
0.5

Additional Information

Equation 53 in https://arxiv.org/abs/1007.1727

Code of Conduct

  • I agree to follow the Code of Conduct
@kratsg kratsg added feat/enhancement New feature or request needs-triage Needs a maintainer to categorize and assign labels Sep 3, 2021
@matthewfeickert matthewfeickert added docs Documentation related and removed needs-triage Needs a maintainer to categorize and assign labels Sep 4, 2021
@alexander-held
Copy link
Member

In this context it might also be nice to include the approximation via best-fit POI value divided by its uncertainty.

@kratsg
Copy link
Contributor Author

kratsg commented Oct 4, 2021

include the approximation via best-fit POI value divided by its uncertainty.

what do you mean?

@alexander-held
Copy link
Member

Assuming Gaussianity, the significance is (best-fit POI value) / (POI uncertainty), e.g. for mu = 1 +/- 0.5 this would translate to 2 sigma.

@kratsg
Copy link
Contributor Author

kratsg commented Oct 4, 2021

Hrmm, isn't that generally seen more like the z-score, rather than significance? (e.g. the distinction between p-value and z-score...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related feat/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants