Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some possible cleanup / extra testing #1685

Closed
henryiii opened this issue Nov 8, 2021 · 1 comment · Fixed by #1773
Closed

chore: some possible cleanup / extra testing #1685

henryiii opened this issue Nov 8, 2021 · 1 comment · Fixed by #1773
Assignees
Labels
chore Other changes that don't modify src or test files

Comments

@henryiii
Copy link
Member

henryiii commented Nov 8, 2021

The old black Jupyter code still needs to be removed:

pyhf/pyproject.toml

Lines 78 to 79 in c493c7c

[tool.nbqa.config]
black = "pyproject.toml"

(and a line below)

pyhf/pyproject.toml

Lines 81 to 82 in c493c7c

[tool.nbqa.mutate]
black = 1

The pytest adpdotps probably could do without the ignores? What are they for?

pyhf/pyproject.toml

Lines 44 to 55 in c493c7c

addopts = [
"--ignore=setup.py",
"--ignore=validation/",
"--ignore=binder/",
"--ignore=docs/",
"--cov=pyhf",
"--cov-report=term-missing",
"--cov-config=.coveragerc",
"--cov-report=xml",
"--doctest-modules",
"--doctest-glob='*.rst'"
]

Some of the options here for pytest might be useful:
https://scikit-hep.org/developer/pytest#configuring-pytest

I’d probably at least put the lower bound requirements into tests, that’s not a public thing really. Keeping the main directory from getting too big reduces user scrolling.

@matthewfeickert matthewfeickert self-assigned this Nov 9, 2021
@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Nov 9, 2021
@matthewfeickert
Copy link
Member

Thanks for following up here like I requested @henryiii. :) I'll do some cleaning on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants