Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codemeta lower bounds #1999

Closed
matthewfeickert opened this issue Sep 12, 2022 · 0 comments · Fixed by #2000
Closed

Update codemeta lower bounds #1999

matthewfeickert opened this issue Sep 12, 2022 · 0 comments · Fixed by #2000
Assignees
Labels
bug Something isn't working CI CI systems, GitHub Actions

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Sep 12, 2022

After Issue #1990 had the workflow fixed by PR #1995, the codemeta comparison check is still failing with

<     "version": ">=3.0.0"
---
>     "version": ">=4.15.0"
91c91
<     "version": ">=1.3.0"
---
>     "version": ">=1.4.0"

This is because jsonschema needs to get updated from v3.0.0

pyhf/codemeta.json

Lines 75 to 87 in 7cc4b78

{
"@type": "SoftwareApplication",
"identifier": "jsonschema",
"name": "jsonschema",
"provider": {
"@id": "https://pypi.org",
"@type": "Organization",
"name": "The Python Package Index",
"url": "https://pypi.org"
},
"runtimePlatform": "Python 3",
"version": ">=3.0.0"
},

to v4.15.0

pyhf/setup.cfg

Line 41 in 7cc4b78

jsonschema>=4.15.0 # for utils

and importlib-resources needs to get updated from 1.3.0

pyhf/codemeta.json

Lines 114 to 126 in 7cc4b78

{
"@type": "SoftwareApplication",
"identifier": "importlib-resources",
"name": "importlib-resources",
"provider": {
"@id": "https://pypi.org",
"@type": "Organization",
"name": "The Python Package Index",
"url": "https://pypi.org"
},
"runtimePlatform": "Python 3",
"version": ">=1.3.0"
},

to 1.4.0.

pyhf/setup.cfg

Line 44 in 7cc4b78

importlib_resources>=1.4.0; python_version < "3.9" # for resources in schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant