Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup extra "complete" no longer exists, but is mentioned in contribution docs #2110

Closed
1 task done
alexander-held opened this issue Feb 9, 2023 · 3 comments · Fixed by #2113
Closed
1 task done
Assignees
Labels
docs Documentation related

Comments

@alexander-held
Copy link
Member

Summary

The "complete" setup extra no longer exists, but the contributing docs mention it. Should presumably be replaced by "all"

Documentation Page Link

https://github.com/scikit-hep/pyhf/blob/main/CONTRIBUTING.md#installing-the-development-environment

Code of Conduct

  • I agree to follow the Code of Conduct
@alexander-held alexander-held added docs Documentation related needs-triage Needs a maintainer to categorize and assign labels Feb 9, 2023
@alexander-held
Copy link
Member Author

This also affects https://scikit-hep.org/pyhf/development.html.

@matthewfeickert
Copy link
Member

Yeah, I had left this as is until we figured out how to do developer environments in hatch in #2096 but I can amend this now and then revise it again if needed.

@matthewfeickert
Copy link
Member

Should presumably be replaced by "all"

Not quite. We made all to be user facing

all = ["pyhf[backends,xmlio,contrib,shellcomplete]"]

while complete used to install all the developer dependencies as well. That currently doesn't exist anymore.

@matthewfeickert matthewfeickert self-assigned this Feb 10, 2023
@matthewfeickert matthewfeickert removed the needs-triage Needs a maintainer to categorize and assign label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants