Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistoSys and OverallSys with shared nuisance parameters are not supported #275

Closed
2 tasks
lukasheinrich opened this issue Sep 19, 2018 · 2 comments
Closed
2 tasks
Assignees
Labels
bug Something isn't working

Comments

@lukasheinrich
Copy link
Contributor

lukasheinrich commented Sep 19, 2018

Description

In the case we added here #272 roohf allows multiple modifiers of different type to share the same nuisance paramerers. We need to support this, and in principle it's is not a big issue. For it we need to

  • decouple constraint pdfs from modifiers
  • deprecate qualify_names

similar to how samples can subscribe to modifiers and many samples can hook into the same modifier, modifiers can subscribe to constraint terms, where many modifiers hook into the same constraint terms.

Some checking needs to occur because not all modifiers can work with all constraint terms

@lukasheinrich lukasheinrich self-assigned this Sep 19, 2018
@lukasheinrich lukasheinrich added the bug Something isn't working label Sep 19, 2018
@kratsg
Copy link
Contributor

kratsg commented Sep 19, 2018

Also additionally deprecate qualify_names as well.

@kratsg
Copy link
Contributor

kratsg commented Nov 8, 2018

Done with #354 and #358.

@kratsg kratsg closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants