Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MXNet Support #593

Closed
matthewfeickert opened this issue Oct 2, 2019 · 7 comments · Fixed by #607
Closed

Drop MXNet Support #593

matthewfeickert opened this issue Oct 2, 2019 · 7 comments · Fixed by #607
Labels
question Further information is requested

Comments

@matthewfeickert
Copy link
Member

Description

MXNet isn't going to be implementing statistical distributions anytime soon, so it seems like they will be diverging from the rest of our ML framework backends even more. Instead of keeping MXNet around as a vestigial dependency I would suggest we just drop support for it.

Thoughts @kratsg @lukasheinrich?

@kratsg
Copy link
Contributor

kratsg commented Oct 2, 2019

MXNet isn't going to be implementing statistical distributions anytime soon

how do we know?

@kratsg kratsg added the question Further information is requested label Oct 2, 2019
@matthewfeickert
Copy link
Member Author

how do we know?

This issue makes it seem like having dedicated distributions with full functionality like TF and PyTorch isn't going to happen right away. The PR that is linked at the very end of it does add sampling (presumably in the next release) but it again lacks the full feature set of the other backends.

In my mind it makes more sense to just discontinue any effort on MXNet and think more about PR #377 instead.

@lukasheinrich
Copy link
Contributor

I think it would be a good idea to replace MXNet with jax (#377 ) it's a more fully featured backend that has

  • hardware support
  • autodifferentiation
  • very similar to numpy

and could actually be the one backend that makes things faster than numpy (currently pytorch and tf are only faster in very extreme cases)

@kratsg
Copy link
Contributor

kratsg commented Oct 9, 2019

Does jax support distributions?

@lukasheinrich
Copy link
Contributor

yeah: https://jax.readthedocs.io/en/latest/jax.scipy.html#module-jax.scipy.stats

@matthewfeickert
Copy link
Member Author

@kratsg Given the 👍 I assume you have no qualms with me opening a MR for a branch in which I've already done this?

@kratsg
Copy link
Contributor

kratsg commented Oct 9, 2019

yes, no qualms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants