Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform() method for the shogun_LMNN #29

Closed
anirudt opened this issue Sep 15, 2016 · 3 comments
Closed

transform() method for the shogun_LMNN #29

anirudt opened this issue Sep 15, 2016 · 3 comments

Comments

@anirudt
Copy link
Contributor

anirudt commented Sep 15, 2016

Going by the current implementation, it lacks a transform() and metric() for the Shogun wrapping implementation of the LMNN.

In case it is required / Unless someone is currently working on it, I would like to work on it.

Open to suggestions!

@perimosocordiae
Copy link
Contributor

Both the shogun and pure Python implementations of LMNN use the BaseMetricLearner (superclass) implementation of transform() and metric(), so no action is required here.

@anirudt
Copy link
Contributor Author

anirudt commented Sep 15, 2016

My apologies, didn't notice that! Is there a nice point for me to start contributing to the community? :)

@perimosocordiae
Copy link
Contributor

The algorithm wish list (#13) is a good place to start! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants