-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove optional ase dependency #231
Labels
Comments
I would extract the arrays and keep them either as plain ascii files or in the numpy format. We can keep the xyz file if we like. |
What basically is to be done is saving the scikit-matter/src/skmatter/datasets/_base.py Lines 121 to 150 in bc76938
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The new ase release break some example notebooks. The ase dependency comes from one roy dataset (see
scikit-matter/src/skmatter/datasets/_base.py
Line 121 in bc76938
and can easily removed as dependency by just storing the arrays inside the ase frames. We could even try to just use numpys loadtxt, then we don't need to change the binary data file.
The text was updated successfully, but these errors were encountered: