You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was in the process of adding a new table. I updated the local Makefile.am file and it took me a few minutes to figure out, why the .txt.in-file was not picked up. Of course I forgot to also modify confiure.ac!
I have two proposals to simplify the process of adding new tables:
1. Remove .txt.in-file processing from autoconf
Given that the main purpose (and currently, only purpose, it seems) to have .txt.in-files and subsequent conversion to .txt-files is to substitute @SCIM_ICONDIR@ to the correct directory, I would question if using autoconf for that purpose it a bit of an overkill. Sure, autoconf does the job right, however it is way more useful for substitution in Makefile.in files, which may have many different variables to substitute. Makefiles also don't increase in number throughout the lifetime of the project too much.
The .txt.in to .txt transform above is very easy to accomplish with a one-liner sed rule. That would remove the need of keeping the up-to-date list of .txt.in-files in configure.ac -- they are already listed in their respective Makefile.am-files.
2. Move common code of Makefile.in-files from tables/*/ into a common Makefile
The Makefile.in-files from the sub-directories of the tables directory are very repetitive! They only differ in "scim_tables_source = ..." line. The rest of the file (turning scim_tables_sources into scim_tables and scim_tables_bin_DATA, rules for building bin-files, etc) can be moved out into a single Makefile that all others can include.
This would greatly simplify the task of adding a table as that would mean adding a single filename to a single file.
Of course, I don't see scim-tables changing too often, so feel free to ignore my suggestion, but in case you're interested I could volunteer some pull-requests to accomplish the above.
The text was updated successfully, but these errors were encountered:
Hi,
I was in the process of adding a new table. I updated the local Makefile.am file and it took me a few minutes to figure out, why the .txt.in-file was not picked up. Of course I forgot to also modify confiure.ac!
I have two proposals to simplify the process of adding new tables:
1. Remove .txt.in-file processing from autoconf
Given that the main purpose (and currently, only purpose, it seems) to have .txt.in-files and subsequent conversion to .txt-files is to substitute @SCIM_ICONDIR@ to the correct directory, I would question if using autoconf for that purpose it a bit of an overkill. Sure, autoconf does the job right, however it is way more useful for substitution in Makefile.in files, which may have many different variables to substitute. Makefiles also don't increase in number throughout the lifetime of the project too much.
The .txt.in to .txt transform above is very easy to accomplish with a one-liner sed rule. That would remove the need of keeping the up-to-date list of .txt.in-files in configure.ac -- they are already listed in their respective Makefile.am-files.
2. Move common code of Makefile.in-files from tables/*/ into a common Makefile
The Makefile.in-files from the sub-directories of the tables directory are very repetitive! They only differ in "scim_tables_source = ..." line. The rest of the file (turning scim_tables_sources into scim_tables and scim_tables_bin_DATA, rules for building bin-files, etc) can be moved out into a single Makefile that all others can include.
This would greatly simplify the task of adding a table as that would mean adding a single filename to a single file.
Of course, I don't see scim-tables changing too often, so feel free to ignore my suggestion, but in case you're interested I could volunteer some pull-requests to accomplish the above.
The text was updated successfully, but these errors were encountered: