First support for testing containers. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new engines are created. container.py is used for manipulation with containers w/o S2I support. s2i_container.py is used for manipulation with containers with s2i support. Podman Wrapper is used for working with podman / docker binaries Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
The working solution can be seen here sclorg/httpd-container#234 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
support_container_tests_part1
branch
from
d745295 to
50a90a1
Compare
and 'test/examples/Dockerfile.s2i' Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
In case 'user_id' is not defined then function returns None Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
|
Let's get merge it so the PR is not so big. |
SlouchyButton
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First support for testing containers.
The new engines are created.
container.py is used for manipulation with containers w/o S2I support. s2i_container.py is used for manipulation with containers with s2i support. Podman Wrapper is used for working with podman / docker binaries