Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: specs/multispec.yml should be in deps for each distgen rule #87

Closed
praiskup opened this issue May 11, 2018 · 2 comments
Closed

make: specs/multispec.yml should be in deps for each distgen rule #87

praiskup opened this issue May 11, 2018 · 2 comments

Comments

@praiskup
Copy link
Contributor

No description provided.

@praiskup praiskup changed the title specs/multispec.yml should be in deps for each distgen rule make: specs/multispec.yml should be in deps for each distgen rule May 11, 2018
@phracek
Copy link
Member

phracek commented Sep 18, 2024

I don't follow this pull request. distgen containers are checked by GitHub Action.

In case this issue is still valid feel free to re-open it.

We do not have enough resources to fixing it.

@phracek phracek closed this as completed Sep 18, 2024
@frenzymadness
Copy link
Member

As I understand it, Pavel wants distgen to run before every other action in make which would prevent building container images from outdated sources - that might happen if you forget to regenerate then after you change the specs and templates and before you build the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@praiskup @phracek @frenzymadness