Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable testing and pushing to quay.io for CentOS7 image #520

Merged
merged 3 commits into from
Aug 4, 2023
Merged

disable testing and pushing to quay.io for CentOS7 image #520

merged 3 commits into from
Aug 4, 2023

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Jul 17, 2023 •
edited
Loading

and migrate from f35 to f37 for fedora images, as f35 is now EOL

@zmiklank zmiklank force-pushed the deprecate_centos branch 3 times, most recently from 2fb6c8a to 9137d5e Compare July 17, 2023 14:59
@zmiklank
Copy link
Contributor Author

@pkubatrh not sure, how to deal with centos7 containerfiles in distgen-generated containers. Is it enough to disable testing and pushing, like it is done in this PR?
Or should the centos7 containerfiles be also removed from the distgen matrix?

@zmiklank zmiklank mentioned this pull request Jul 17, 2023
Closed
phracek
phracek requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fedora tests are failing and we need to fix it. Although it is not related to this pull rquest.

@phracek
Copy link
Member

phracek commented Jul 24, 2023

[test-openshift]

@zmiklank
Copy link
Contributor Author

Fedora tests are failing and we need to fix it. Although it is not related to this pull rquest.

It is problem on rpm level. This rpm update should fix it:
https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2023-e6d66cd1a4

@pkubatrh
Copy link
Member

not sure, how to deal with centos7 containerfiles in distgen-generated containers. Is it enough to disable testing and pushing, like it is done in this PR?
Or should the centos7 containerfiles be also removed from the distgen matrix?

That is a tricky question. Is it possible to keep generating all the files needed for centos7 images, but add .exclude file generation on top of that, or would that be too much complexity?

@zmiklank
Copy link
Contributor Author

not sure, how to deal with centos7 containerfiles in distgen-generated containers. Is it enough to disable testing and pushing, like it is done in this PR?
Or should the centos7 containerfiles be also removed from the distgen matrix?

That is a tricky question. Is it possible to keep generating all the files needed for centos7 images, but add .exclude file generation on top of that, or would that be too much complexity?

IMO too much complexity for the first of deprecation steps. But a feasible way could be to keep the centos7 config files for distgen and only add centos7-exclude rule to the exclude matrix in here. That way would be really easy to enable their generation again if someone requests it.

@pkubatrh
Copy link
Member

But a feasible way could be to keep the centos7 config files for distgen and only add centos7-exclude rule to the exclude matrix in here. That way would be really easy to enable their generation again if someone requests it.

Agreed, I wanted to suggest exactly this if we did not want to add creation of exclude files. So keeping the sources while also not generating the result for centos7 is ok as far as I am concerned.

@zmiklank
disable testing and pushing to quay.io for CentOS7 image
01bb122 
The CentOS registry has been decommissioned[1]. Alternative registries
provide only old versions of CentOS base image. Because there is no
known possibility currently to obtain fresh CentOS7 base container image
(we do not want to update old images with yum -y update) we are stopping
rebuilds of the SCLorg's s2i-images too.  Already built images will be
still available on quay.io.

[1] https://lists.centos.org/pipermail/centos-devel/2023-May/142956.html
@phracek
Copy link
Member

phracek commented Jul 26, 2023

@pkubatrh not sure, how to deal with centos7 containerfiles in distgen-generated containers. Is it enough to disable testing and pushing, like it is done in this PR?
Or should the centos7 containerfiles be also removed from the distgen matrix?

I would only remove testing and pushing image from TFAGA. The users should have still possibility to use CentOS 7 images. But this is only my opinion.

@zmiklank
Copy link
Contributor Author

@pkubatrh not sure, how to deal with centos7 containerfiles in distgen-generated containers. Is it enough to disable testing and pushing, like it is done in this PR?
Or should the centos7 containerfiles be also removed from the distgen matrix?

I would only remove testing and pushing image from TFAGA. The users should have still possibility to use CentOS 7 images. But this is only my opinion.

In theory they still can. They can take the Dockerfile from git history. Or remove centos7 from exclude matrix and generate the Dockerfile locally.

@zmiklank
Copy link
Contributor Author

It looks like we'll need to wait for the postgres fix a bit longer.

@pkubatrh
Copy link
Member

pkubatrh commented Aug 2, 2023

[test]

@zmiklank
Copy link
Contributor Author

zmiklank commented Aug 2, 2023

migrated to f38 instead.

@zmiklank zmiklank mentioned this pull request Aug 3, 2023
Closed
@zmiklank
Copy link
Contributor Author

zmiklank commented Aug 3, 2023

[test]

@zmiklank
Copy link
Contributor Author

zmiklank commented Aug 3, 2023

Tests for Testing Farm - Fedora - 14 failed - problem is missing pgaudit in module of postresql:14 in Fedora 38. Fix is on its way on RPM level.

@zmiklank
Copy link
Contributor Author

zmiklank commented Aug 4, 2023

I am not sure if we ever merge this PR :D.
Now the Testing Farm crashes on Fedora:
�[31m[06:33:36] [E] [Fedora-latest:x86_64:/plans/fedora/test-ci] guest provisioning failed: Guest couldn't be provisioned: Artemis resource ended in 'error' state�[0m

pkubatrh
pkubatrh approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@pkubatrh pkubatrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 14 on Fedora tested locally and is green. LGTM

@zmiklank zmiklank merged commit f3820e5 into sclorg:master Aug 4, 2023
@zmiklank zmiklank mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek requested changes

@pkubatrh pkubatrh pkubatrh approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmiklank @phracek @pkubatrh