-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_pgaudit_test
crashing the test suite
#595
Comments
Problem is that This can be fixed with replacing check for existing variable with check for empty variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was introduced by #399.
A new test introduced this line in
run_pgaudit_test
, which in the PR had an error:-v DOCKER_EXTRA_ARGS || cp -r "$test_dir"/examples/pgaudit/* "$config_dir"
The line is missing test at the beginning, so that the new test
run_new_pgaudit_test
, which doesn't really test pgaudit, rather custom extension loading via container argument, takes precedence over the custom config that is in therun_pgaudit_test
to load pgaudit.The problem is that if the config is not present, the whole test crashes with the error:
Interesting is that it fully stops further testing, but won't really crash the testsuite as the testsuite will gracefully clean all the containers.
Another weird thing is that it fails on
run_pg_audit_test
already, not the newrun_new_pgaudit_test
.Ideally, the test suite should still continue and mention that this test failed as described previously in this issue.
This is related to #537 where this issue was first spotted while reviewing aforementioned PR. At some later point a mistake was introduced into the PR which made test always copy the config files and generating an error (that was not caught, so tests passed). This mistake was not caught when merging the PR at that point and also made all tests pass as the changes weren't used in the test.
This mistake then started generating
-v: command not found
error in logs.After fixing this issue, tests are not passing - with the same problem as from the original PR.
The text was updated successfully, but these errors were encountered: