Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile.rhel8 for version 5.32 #308

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add Dockerfile.rhel8 for version 5.32 #308

merged 1 commit into from
Jun 26, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Jun 20, 2024

Add Dockerfile.rhel8 for version 5.32
Support start since May 2022.

This pull request adds support for building and testing version 5.32 in RHEL8

Closes: #306

Support start since May 2022

Closes: #306

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 20, 2024

[test]

@phracek
Copy link
Member Author

phracek commented Jun 20, 2024

@jplesnik @michal-josef-spacek Please take a look at it? Thanks. Support is since May 2022 till Apr 2025.

We forgot it totally.

@phracek
Copy link
Member Author

phracek commented Jun 24, 2024

For faster review, diff between 5.32/Dockerfile.rhel8 and 5.32/Dockerfile.rhel9:

diff Dockerfile.rhel8 Dockerfile.rhel9
1c1
< FROM ubi8/s2i-base:1
---
> FROM ubi9/s2i-base:1
29c29
<       name="ubi8/${NAME}-${PERL_SHORT_VER}" \
---
>       name="ubi9/${NAME}-${PERL_SHORT_VER}" \
35c35
<       usage="s2i build <SOURCE-REPOSITORY> ubi8/${NAME}-${PERL_SHORT_VER}:latest <APP-NAME>"
---
>       usage="s2i build <SOURCE-REPOSITORY> ubi9/${NAME}-${PERL_SHORT_VER}:latest <APP-NAME>"
38,39d37
< RUN yum -y module reset perl
<
41d38
<     yum -y module enable perl:$PERL_VERSION && \

Copy link
Member

@pkubatrh pkubatrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michal-josef-spacek
Copy link
Member

lgtm too.
I tested it and it seems ok.

@phracek phracek merged commit 6910f17 into master Jun 26, 2024
7 checks passed
@phracek phracek deleted the add_perl_532_rhel8 branch June 26, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 5.32 version to RHEL8
4 participants