-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for incremental builds #304
Comments
Could you please provide more info? What do you mean by incremental builds and why is this important? |
@omron93 Do we use incremental builds in other containers? |
@torsava soon in nodejs: sclorg/s2i-nodejs-container#201 |
@pkubatrh Ah, thanks. I thought the incremental build feature of s2i was kinda buggy/unfinished. So I would probably wait to see how it works out for nodejs, see if they can work out the kinks before implementing it here. |
@pkubatrh @torsava https://github.com/sclorg/golang-container supports incremental builds for some time already. I'm not aware of any problems with it. @jcajka Are you? |
I think this would really help adoption. Right now, using s2i means waiting for a really slow build vs. a Dockerfile where requirements.txt would be cached. |
I just found this article about how to make incremental builds work using s2i python container. https://developpaper.com/using-s2i-to-build-images-from-source-code/ |
So, If I understand it correctly from the node and go containers, it should work for Python container like this:
Is that correct? I don't use s2i because it does not support podman so is there any significant difference when s2i is used and a user does not have to prepare its own dockerfile manually? |
No description provided.
The text was updated successfully, but these errors were encountered: