Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add integration test for pull_request_target #139

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

zmiklank
Copy link
Collaborator

@zmiklank zmiklank commented Mar 22, 2024

Would be good to have some simple setup for different targets in our integration tests.
I am setting this to a draft for now, as we need to make sure the test is written safely before we merge it.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (c41d749) to head (a827754).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          14       14           
  Lines         860      860           
  Branches      157      157           
=======================================
  Hits          787      787           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmiklank

This comment was marked as outdated.

@jamacku

This comment was marked as outdated.

@jamacku

This comment was marked as outdated.

Copy link

github-actions bot commented Oct 2, 2024

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Variables testFedora-latestx86_64✅ passed02.10.2024 08:30:373min test pipeline
Secrets testFedora-latestx86_64✅ passed02.10.2024 08:31:172min 58stest pipeline
Smoke testFedora-latestx86_64✅ passed02.10.2024 08:32:053min 29stest pipeline
Timeout testFedora-latestx86_64✅ passed02.10.2024 08:30:458min 4stest pipeline

@jamacku
Copy link
Member

jamacku commented Oct 2, 2024

@zmiklank I'm sorry for hijacking your PR. I believe that it is now ready to be merged.

@phracek, Could you please have a look?

@jamacku jamacku requested a review from phracek October 2, 2024 11:13
@jamacku jamacku marked this pull request as ready for review October 3, 2024 11:03
@jamacku jamacku merged commit b29fa07 into sclorg:main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants