Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom header support for webhooks #32

Open
esep opened this issue Dec 1, 2021 · 0 comments
Open

Custom header support for webhooks #32

esep opened this issue Dec 1, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@esep
Copy link

esep commented Dec 1, 2021

Issue description

In the SCM Manager Webhook page, I can currently input the URL with HTTP method, but no headers such as api keys that would be required by e.g. Fisheye and other APIs. Because of this, I have to use other hook methods, such as curl commands.

For example, see:
https://confluence.atlassian.com/fisheye/configuring-commit-hooks-960155647.html

Feature Request

Problem to be solved

I would like to be able to add custom headers to the requests sent by the webhook.

Proposed solution

Support for adding/removing custom headers (key-value pairs) should be added to the webhook page (js React files) so that they would be passed on to the request that is sent in the class:
https://github.com/scm-manager/scm-webhook-plugin/blob/develop/src/main/java/sonia/scm/webhook/impl/AhcWebHookHttpClient.java

@pfeuffer pfeuffer added enhancement New feature or request help wanted Extra attention is needed labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants