Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integration test to CI #129

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Conversation

scolladon
Copy link
Owner

and also cleanup the steps name

What does this pull request contains? Explain your changes.


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Add integration testing in the CI/CD.
It will help detects when a PR is breaking the plugin assembly

Any other comments?


Will be added to the PR checks once merged.
Integration of this PR not relevant to a release

Where has this been tested?


GH Action of this PR

@scolladon scolladon requested a review from mehdicherf April 17, 2021 14:29
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #129 (64981cc) into master (ef45931) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 64981cc differs from pull request most recent head e1ad8d5. Consider uploading reports for the commit e1ad8d5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   99.24%   99.24%   -0.01%     
==========================================
  Files          18       18              
  Lines         399      395       -4     
==========================================
- Hits          396      392       -4     
  Misses          3        3              
Impacted Files Coverage Δ
src/service/inFileHandler.js 100.00% <0.00%> (ø)
src/service/inFolderHandler.js 100.00% <0.00%> (ø)
src/service/standardHandler.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef45931...e1ad8d5. Read the comment docs.

@scolladon scolladon force-pushed the tech/add-ci-integration-test branch 5 times, most recently from 7740292 to 7df69cd Compare April 17, 2021 15:32
and also cleanup the steps name

feat: install via npm
style: change name of publish job
@scolladon scolladon force-pushed the tech/add-ci-integration-test branch from 7df69cd to e1ad8d5 Compare April 20, 2021 15:29
@scolladon scolladon merged commit 6af29ac into master Apr 20, 2021
@scolladon scolladon deleted the tech/add-ci-integration-test branch April 20, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants