Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inResource file identification #178

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Aug 4, 2021

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


fix the way we identify files contained in Resource metadata kind (staticresource, lwc, aura, experiences, waveTemplate) to be copied

Does this close any currently open issues?


closes #176

  • Jest test to check the fix is applied are added.

Any particular element to being able to test locally


Any other comments?


Available for the next release

Where has this been tested?


Operating System: Darwin Kernel Version 19.6.0: Tue Jun 22 19:49:55 PDT 2021; root:xnu-6153.141.35~1/RELEASE_X86_64

yarn version: 1.22.11

node version: v14.16.0

git version: 2.32.0

sfdx version: sfdx-cli/7.110.0 darwin-x64 node-v14.16.0

sgd plugin version: 4.7.2

@scolladon scolladon requested a review from mehdicherf August 4, 2021 12:29
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #178 (07f64f0) into master (d0f99b8) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #178      +/-   ##
===========================================
- Coverage   100.00%   99.77%   -0.23%     
===========================================
  Files           18       18              
  Lines          440      440              
===========================================
- Hits           440      439       -1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/service/inResourceHandler.js 96.00% <100.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f99b8...07f64f0. Read the comment docs.

@scolladon scolladon changed the title fix: staticresources element name resolution fix: inResource file identification Aug 4, 2021
@scolladon scolladon enabled auto-merge (squash) August 4, 2021 12:30
@scolladon scolladon disabled auto-merge August 4, 2021 12:37
@scolladon scolladon enabled auto-merge (squash) August 4, 2021 13:00
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2021

Code Climate has analyzed commit 07f64f0 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit dda6327 into master Aug 4, 2021
@scolladon scolladon deleted the fix/inResource-naming-collision branch August 4, 2021 13:48
@alexmodis
Copy link

I should wait for the new release to reach npm I guess ?

@scolladon
Copy link
Owner Author

Yes, new release available (4.8.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A forceignored file is still copied into output directory
3 participants