fix: issue when filtering same file name for different metadata #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and refactor to a more OOP approach
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 20 +1
Lines 462 482 +20
=========================================
+ Hits 462 482 +20
Continue to review full report at Codecov.
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| line | ||
| .split(path.sep) | ||
| .some(part => Object.prototype.hasOwnProperty.call(metadata, part)) | ||
| _treatResult(repoDiffResult) { |
There was a problem hiding this comment.
Function _treatResult has 26 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit 886589f and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains
Explain your changes
It builds a more complete base of comparison to detect which file is deleted, renamed, added, moved by taking part of the path containing available metadata type.
For exemple :
force-app/main/default/objects/Account/fields/CustomField__c.field-meta.xmlbefore the algorithm was taking
CustomField__c.field-meta.xmlas comparison elementnow it takes
objects/Account/fields/CustomField__c.field-meta.xmlwhich allow to have the same field for another object being manipulated by the plugin
Does this close any currently open issues?
closes #193
Any particular element to being able to test locally
You can use the sgd reproduction playground branch issue/193 to test current version of sgd (4.9.0) against the one in this PR
Any other comments?
Next release can be considered to ship this
Where has this been tested?
Operating System: Darwin Kernel Version 19.6.0: Thu Sep 16 20:58:47 PDT 2021; root:xnu-6153.141.40.1~1/RELEASE_X86_64
yarn version: 1.22.11
node version: v16.10.0
git version: 2.33.0
sfdx version: sfdx-cli/7.120.0 darwin-x64 node-v16.10.0
sgd plugin version: 4.9.0