Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decommissionate sgd #221

Merged
merged 2 commits into from
Feb 25, 2022
Merged

feat: decommissionate sgd #221

merged 2 commits into from
Feb 25, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contains

It removes legacy sgdcommand


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes

Remove executable files, related tests and mention in the documentation


@scolladon scolladon requested a review from mehdicherf December 9, 2021 22:00
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #221 (a803b61) into main (d87fac3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          22       22           
  Lines         585      585           
=======================================
  Hits          577      577           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87fac3...a803b61. Read the comment docs.

@scolladon scolladon changed the base branch from master to main December 18, 2021 14:59
@scolladon scolladon force-pushed the feat/decommissionate-sgd branch from bcf8fec to a1b9768 Compare December 18, 2021 15:07
@scolladon scolladon force-pushed the feat/decommissionate-sgd branch from 1f41b21 to a803b61 Compare February 25, 2022 14:17
@codeclimate
Copy link

codeclimate bot commented Feb 25, 2022

Code Climate has analyzed commit a803b61 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon changed the title chore: decommissionate sgd feat: decommissionate sgd Feb 25, 2022
@scolladon scolladon merged commit ecd146f into main Feb 25, 2022
@scolladon scolladon deleted the feat/decommissionate-sgd branch February 25, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants