fix: ignore white space parameter --ignore-whitepsace, -W
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
===========================================
+ Coverage 98.63% 100.00% +1.36%
===========================================
Files 22 22
Lines 585 598 +13
===========================================
+ Hits 577 598 +21
+ Misses 8 0 -8
Continue to review full report at Codecov.
|
scolladon
changed the title
--word-diff-regex--ignore-whitepsace, -W
scolladon
force-pushed
the
fix/ignore-whitespace-word-diff-regex-overfiltering
branch
from
ffd81ca to
5ef3347
Compare
|
Code Climate has analyzed commit 5ef3347 and detected 0 issues on this pull request. View more on Code Climate. |
mehdicherf
approved these changes
Mar 18, 2022
scolladon
deleted the
fix/ignore-whitespace-word-diff-regex-overfiltering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contains
Explain your changes
Fix
--word-diff-regexby setting it to the default git value :--word-diff-regex=|[^[:space:]]use
git diff --numstatwith--no-renamesand--diff-filter=ADMinstead of--name-statusin order to solve the issue with-Wparameter not being applied with--name-statusAdd unit test to avoid future regression
Improve test coverage
Does this close any currently open issues?
closes #262
Any particular element to being able to test locally
Use the branch issue/262 to test the fix from the reproduction playground
Any other comments?
Can be shipped in the next release
Where has this been tested?
Operating System: Darwin Kernel Version 19.6.0: Thu Jan 13 01:26:33 PST 2022; root:xnu-6153.141.51~3/RELEASE_X86_64
yarn version: 1.22.15
node version: v14.19.0
git version: 2.35.1
sfdx version: sfdx-cli/7.142.1 darwin-x64 node-v14.19.0
sgd plugin version: 5.0.2