Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document file copy when metafile is modified #276

Merged
merged 7 commits into from
Mar 24, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Make sure document file (even with special extension like .png for example) is copied alongside its meta file when its meta file is modified

Does this close any currently open issues?


closes #272

  • Jest test to check the fix is applied are added.

@scolladon scolladon requested a review from mehdicherf as a code owner March 23, 2022 23:35
@codeclimate
Copy link

codeclimate bot commented Mar 23, 2022

Code Climate has analyzed commit 729f46b and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #276 (729f46b) into main (12ddfc6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          607       613    +6     
=========================================
+ Hits           607       613    +6     
Impacted Files Coverage Δ
src/service/inFileHandler.js 100.00% <ø> (ø)
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/standardHandler.js 100.00% <100.00%> (ø)
src/service/subCustomObjectHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ddfc6...729f46b. Read the comment docs.

@scolladon scolladon merged commit 30f972e into main Mar 24, 2022
@scolladon scolladon deleted the fix/document-metadata-change branch March 24, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document files are not delta generated when metafile is changed
2 participants