-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new default api version definition algorithm #372
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 767 792 +25
=========================================
+ Hits 767 792 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6d309c1
to
fb68cb2
Compare
fb68cb2
to
9f20873
Compare
Co-authored-by: Mehdi Cherfaoui <mcherfaoui@salesforce.com>
Code Climate has analyzed commit 1c11843 and detected 0 issues on this pull request. View more on Code Climate. |
What does this pull request contain?
Explain your changes
When
--api-version
parameter is set then use this versionElse try to find the
sourceApiVersion
from thesfdx-project.json
If the API version found is not handled by the plugin then use the latest and log a warning in the result
Some changes have been required in the
metadataManager
in order to get the latest api version handled by the plugin and to check if a version is managed by the pluginDoes this close any currently open issues?
closes #362
Any particular element that can be tested locally
use the
-a
parameter and play with the possible valuesuse a
sfdx-project.json
file and play with thesourceApiVersion
attribut valueAny other comments
unit tests try to represent the full spec of this feature