fix: readDir git based implementation #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request contain?
Explain your changes
Fix home made git based
readDir
implementation and usagefs.readdir
returns afs.Dirent
data structure which tell us if the element is a folder or a file.Using git to explore folder content returns string.
A element is a folder if it ends with '/'
Some part of the code relied on not having this slash at the end of a file.
Fix config parameter in
fsHelper
Improve error handling in
fsHelper
Does this close any currently open issues?
closes #413
closes #414
closes #416
Any particular element that can be tested locally
Build a lwc component with subfolder (for test for example), modify the js file, check all the content of the module (even sub folder) is copied to output
This playground can be used as well
This branch in our playground can be used as well
Any other comments