Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get parent folder name portability #562

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Fix the way we split the path of a line to get the parent folder
Make sure it works on any path.sep environment specificities

Does this close any currently open issues?


closes #548

@scolladon scolladon requested a review from mehdicherf as a code owner April 4, 2023 17:03
@codeclimate
Copy link

codeclimate bot commented Apr 4, 2023

Code Climate has analyzed commit 402936e and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ddd2d5f) 100.00% compared to head (402936e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #562   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          863       862    -1     
=========================================
- Hits           863       862    -1     
Impacted Files Coverage Δ
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/inResourceHandler.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon merged commit 49b882e into main Apr 4, 2023
@scolladon scolladon deleted the fix/windows-path-separator-for-git branch April 4, 2023 17:24
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Shipped in release v5.17.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore .eslintrc.json at project init
1 participant