Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate delta command not working after migrating from sfdx to sf #746

Closed
1 task
Tanvidh opened this issue Jan 3, 2024 · 23 comments
Closed
1 task

Generate delta command not working after migrating from sfdx to sf #746

Tanvidh opened this issue Jan 3, 2024 · 23 comments
Assignees
Labels
bug Something isn't working CI/CD CI/CD context reproduction steps needed Need reproduction steps to further with the analysis

Comments

@Tanvidh
Copy link

Tanvidh commented Jan 3, 2024

Issue verification check:

  • is the current repository fully deployable at the commit SHA provided with the 'from' parameter of the command?

What is the problem?

SGD command fro generating git delta is failing after migrating sfdx to sf
Version:
Sf:2.11.8
SGD:5.10.0


Getting error for this command

As
error running SGD:source:delta : core_1.Flags.enum is not a function

What is the parameter and the value you used with it?

What is the expected result?

Git delta should get generated

What is the actual result?

error

Steps to reproduce


Execution context


Operating System:

yarn version:

node version:

git version:

sfdx version:

sgd plugin version:

More information (optional)


@Tanvidh Tanvidh added the bug Something isn't working label Jan 3, 2024
@Tanvidh
Copy link
Author

Tanvidh commented Jan 3, 2024

Command used:
Sfdx sgd:source:delta --to branchname --from $(git merge-base branchname) --repo . -outpu delta-source/ --generate-delta

@scolladon
Copy link
Owner

Hi @Tanvidh!

Thanks for raising this issue and thanks for contributing in making this project better!

Could you try with the latest version of sgd please ?
Also can you try with the --output parameter (instead of --outpu) please ?

Let us know what it changes

@Tanvidh
Copy link
Author

Tanvidh commented Jan 3, 2024

Hi @scolladon ,
I tried using latest version for SGD 5.31.1
And command is also using --output.But still it is failing with same error
Nodejs version:18.18.2
Npm version:10.0.0

@scolladon
Copy link
Owner

Thanks @Tanvidh, could you try uninstalling the plugin, uninstalling sf cli, and then reinstalling everything back please ?

@Tanvidh
Copy link
Author

Tanvidh commented Jan 3, 2024

Hi @scolladon ,
We are using CI-CD pipeline which freshly installs the Salesforce cli with every run.
Do you still want to try?.
If yes,if it will work after uninstalling and reinstalling what if we move it main prod level.It would be affect all the pipelines?

Please suggest

@scolladon
Copy link
Owner

scolladon commented Jan 3, 2024

Thanks for the context of execution.
Could you give us more details about it ? What kind of CI/CD ? What OS ?

On our github action pipeline checks, everything looks fine for any OS (mac, linux, windows) for node 18 and node 20.

@Tanvidh
Copy link
Author

Tanvidh commented Jan 3, 2024

Hi @scolladon ,
It is Jenkins CI-CD pipeline.Where in we have Jenkins stage fro generating delta stage
OS is linux-x64
Node 18

@scolladon
Copy link
Owner

Could you share the pipeline definition @Tanvidh ?

Here is a discussion about sgd installation on Jenkins. I don't know if it can help but we never know

@Tanvidh
Copy link
Author

Tanvidh commented Jan 5, 2024

Hi @scolladon ,
Thanks but I am using same commands and everything looks fine from my side.Il share the pipeline file with you .
Meanwhile I just wanted to understand regarding Jenkins node to be used to run node js 20 version and npm 18 version.
Is their any dependency whether we need to use Rhel8 for running the node js > 16 and npm > 14.
Iam using Rhel 8 node agent for running my code on Jenkins.Initially I tried using Linux-Aws but it was failing while installing node js version itself.

@scolladon
Copy link
Owner

Hi @Tanvidh,

I actually do not know what kind of Jenkins setup you need to have to use the plugin.
I have never done that.

I found this documentation about how to setup Jenkins to support sfdx.
I don't know if it works with sf.

We make sure the plugin supports the same node version as the sf cli does to ensure maximum compatibility

@scolladon scolladon changed the title Generate delta command not working after migrating from sfdx to sf[BUG NAME] Generate delta command not working after migrating from sfdx to sf Jan 5, 2024
@scolladon scolladon added the CI/CD CI/CD context label Jan 5, 2024
@Tanvidh
Copy link
Author

Tanvidh commented Jan 17, 2024

Hi @scolladon -Jenkins setup is sorted as sfdx commands are working fine on Jenkins.After migration from sfdx to sf it was working fine.But as the node js version got updated we started facing issues.
For now plugins have been installed correctly.its just failing in generate delta command

@scolladon
Copy link
Owner

scolladon commented Jan 17, 2024

Hi @Tanvidh,

Why it is failing in generate delta command ?
What is the parameter used ?
What is the output you have actually, and what is the output you expect ?
How anyone could reproduce this ?

@Tanvidh
Copy link
Author

Tanvidh commented Jan 18, 2024

It is failing with error as mentioned above
Parameters used are source branch,target branch ,and output file.Command is also pasted above
Expected output is package.xml gets created at specified location
It's simple sfdx git delta plugin wherein generate delta command is used.

@scolladon
Copy link
Owner

Ok @Tanvidh, thanks
Just to be sure, you are not experiencing the same issue locally, right ?
If so, I would try reinstalling everything.
Make sure it has node 18 or 20, git latest and yarn.

@Tanvidh
Copy link
Author

Tanvidh commented Jan 18, 2024

I will try to install locally.But local system is windows and Jenkins is using Linux.So iam trying directly onto Jenkins.
Git version is 2.39.2
Yarn:1.22.21
Nodejs:tried both 18 and 20

@Tanvidh
Copy link
Author

Tanvidh commented Jan 22, 2024

Hi @scolladon
Any update on this?

@scolladon
Copy link
Owner

Not on my side.

I am not able to reproduce the issue.
And others have been able to install sfdx cli and sgd on jenkins.

There may be something special with your installation / environment / jenkins setup
I am afraid without poking around I won't be able to help as I don't see much "unusual" things here

@scolladon
Copy link
Owner

Hi @Tanvidh

Do you have an update on your situation here ?

@Tanvidh
Copy link
Author

Tanvidh commented Feb 16, 2024

@scolladon Can we connect for this issue?.Iam still facing issues with the plugin.Please share the details

@scolladon
Copy link
Owner

Yes sure, we can connect, my email is public on my profile, we could arrange a screen share next week

@scolladon scolladon added the reproduction steps needed Need reproduction steps to further with the analysis label Feb 26, 2024
@scolladon
Copy link
Owner

Hi @Tanvidh !

Do you still have the issue ?
How can I help here ?

@Tanvidh
Copy link
Author

Tanvidh commented Mar 26, 2024

Hi @scolladon -Thanks it's resolved for me .I had to add an extra package @salesforce/source-deply-retrieve in package.json and the issue got resolved.

@scolladon
Copy link
Owner

That's great news @Tanvidh !

Where did you have to add this extra package ?
Maybe your issue is linked to this one and is fixed without having you to add this extra package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD CI/CD context reproduction steps needed Need reproduction steps to further with the analysis
Projects
None yet
Development

No branches or pull requests

2 participants