Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xml header consideration for inFile metadata type handler #811

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Ensure the algorithm behave the same whether there is an xml header or not

Does this close any currently open issues?


closes #806

  • Jest tests added to cover the fix.
  • E2E tests added to cover the fix.

Any particular element that can be tested locally


Use a profile file without xml header

@scolladon scolladon requested a review from mehdicherf as a code owner March 18, 2024 09:00
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ad59dd) to head (3767206).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1039      1041    +2     
  Branches       113       113           
=========================================
+ Hits          1039      1041    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the fix/inFile-pruning branch from 54bf339 to 3767206 Compare March 18, 2024 09:18
Copy link

codeclimate bot commented Mar 18, 2024

Code Climate has analyzed commit 3767206 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 71b1217 into main Mar 18, 2024
20 of 21 checks passed
@scolladon scolladon deleted the fix/inFile-pruning branch March 18, 2024 09:32
Copy link

Shipped in release v5.38.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.38.1

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SGD 5.34.0] [Profiles Are Not Copied in Output Dir]
1 participant