Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absolute path handling #815

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix: absolute path handling #815

merged 4 commits into from
Mar 18, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Make sure leading and trailing path separated are kept

Does this close any currently open issues?


closes #814

  • Jest tests added to cover the fix.

@scolladon scolladon requested a review from mehdicherf as a code owner March 18, 2024 15:16
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b89c806) to head (29f371a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #815   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1041      1041           
  Branches       113       113           
=========================================
  Hits          1041      1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the fix/absolute-path-sanitizing branch from 9429d9b to 29f371a Compare March 18, 2024 15:37
Copy link

codeclimate bot commented Mar 18, 2024

Code Climate has analyzed commit 29f371a and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit a926a88 into main Mar 18, 2024
19 of 21 checks passed
@scolladon scolladon deleted the fix/absolute-path-sanitizing branch March 18, 2024 15:50
Copy link

Shipped in release v5.38.2.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.38.2

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LATEST-RC/5.38.1] [Error folder does not exist]
1 participant