Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detection of CustomMetadata type #844

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Exclude CustomMetadata type from matching with suffix for type detection

Does this close any currently open issues?


closes #830

  • Jest tests added to cover the fix.

@scolladon scolladon requested a review from mehdicherf as a code owner April 22, 2024 20:54
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b161622) to head (792c659).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #844   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1068      1069    +1     
  Branches       115       115           
=========================================
+ Hits          1068      1069    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the fix/custommetadata-type-detection branch from 614a55c to 792c659 Compare April 22, 2024 21:12
Copy link

codeclimate bot commented Apr 22, 2024

Code Climate has analyzed commit 792c659 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Published under dev-844 npm channel.

$ sfdx plugins:install sfdx-git-delta@dev-844

@scolladon scolladon merged commit 412592b into main Apr 22, 2024
17 of 22 checks passed
@scolladon scolladon deleted the fix/custommetadata-type-detection branch April 22, 2024 21:24
Copy link

Shipped in release v5.39.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.39.1

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specificTestClasses is added incorrectly to EmailServicesFunction
1 participant