Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata type detection for subtype not packageable contained inside file #858

Merged
merged 4 commits into from
May 6, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Make sure the plugin detects subtype and copy the file when not packageable subtype are present after pruning a file

Does this close any currently open issues?


closes #857

  • Jest tests added to cover the fix.

@scolladon scolladon requested a review from mehdicherf as a code owner May 5, 2024 17:01
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5941fcd) to head (988b051).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #858   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1069      1067    -2     
  Branches       115       114    -1     
=========================================
- Hits          1069      1067    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon
Copy link
Owner Author

Hi @jfaderanga !

Could you help here and test the fix with the exact context you used to experience the related issue please ?

You can follow those steps to install the dev version locally and test it.

Copy link

codeclimate bot commented May 5, 2024

Code Climate has analyzed commit 988b051 and detected 0 issues on this pull request.

View more on Code Climate.

@jfaderanga
Copy link

Hi @jfaderanga !

Could you help here and test the fix with the exact context you used to experience the related issue please ?

You can follow those steps to install the dev version locally and test it.

Hi @scolladon thanks heaps mate, I've tested both latest and dev in the exact context where we get the issue.
@latest - failed, package xml is empty.
@dev-858 - passed, package xml is not empty.

@scolladon scolladon merged commit a55a528 into main May 6, 2024
18 of 22 checks passed
@scolladon scolladon deleted the fix/inFile-unfiltered-changes branch May 6, 2024 08:38
Copy link

github-actions bot commented May 6, 2024

Shipped in release v5.39.2.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.39.2

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package XML is empty.
2 participants