-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate to plugin v2 #924
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13469 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13471 lines exceeds the maximum allowed for the inline comments feature.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 44 +4
Lines 1018 990 -28
Branches 104 103 -1
=========================================
- Hits 1018 990 -28 ☔ View full report in Codecov by Sentry. |
Need to wait for this issue kaelzhang/node-ignore#96 to be fixed |
c984059
to
ded5517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13725 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13743 lines exceeds the maximum allowed for the inline comments feature.
9a4354a
to
d3c2976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13739 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13957 lines exceeds the maximum allowed for the inline comments feature.
15c63bf
to
18924d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13959 lines exceeds the maximum allowed for the inline comments feature.
18924d6
to
1000228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13966 lines exceeds the maximum allowed for the inline comments feature.
1000228
to
3782651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13966 lines exceeds the maximum allowed for the inline comments feature.
3782651
to
575f0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13966 lines exceeds the maximum allowed for the inline comments feature.
575f0e1
to
ee70dc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13966 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 13990 lines exceeds the maximum allowed for the inline comments feature.
e9204c2
to
3339f8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 14100 lines exceeds the maximum allowed for the inline comments feature.
3339f8d
to
ab29eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 14098 lines exceeds the maximum allowed for the inline comments feature.
ab29eba
to
d8a31de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 14098 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 30751 lines exceeds the maximum allowed for the inline comments feature.
87865b5
to
014402f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 100550 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 99967 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 99962 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 99962 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 99962 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 101106 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 101109 lines exceeds the maximum allowed for the inline comments feature.
40d0a3b
to
6f395a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 101109 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 101529 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 101084 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 101084 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 9ef732b and detected 0 issues on this pull request. View more on Code Climate. |
Published under $ sf plugins install sfdx-git-delta@dev-924 |
Explain Your Changes
This Pull Request introduces significant updates as part of the migration to sfdx-git-delta v6. The changes align with Salesforce CLI v2 architecture and modern best practices. Below are the key updates:
Created a Migration Guide:
A detailed guide has been written to assist users in migrating to the latest version, outlining key differences and steps for a smooth transition.
Upgraded to Salesforce Plugin v2 Architecture:
Migrated the plugin to the sf plugin v2 architecture, benefiting from a more modular and efficient framework, improved performance, and compatibility with the latest CLI innovations.
Updated
file
anddir
Attribute Naming:Changed the
file
anddirectory
parameters to comply with Salesforce CLI naming conventions.See Design Guidelines for Flags.
Removed
success: true
in JSON Output:Simplified the JSON response by removing redundant
success: true
flags. Thestatus
attribute now provides sufficient information.Deprecated Obsolete
outputError
Handling:Error output has been reworked to follow updated CLI error-handling patterns, ensuring a cleaner and more consistent experience.
Fixed
apiVersion
Attribute:Corrected an issue with the
apiVersion
parameter for better accuracy in version handling.Refactored JSON Output (
--json
):JSON output has been refactored to merge seamlessly with the new output structure and remove duplication, improving readability and consistency.
Switched to Module-Type Export:
The plugin now exports as an ESM module, removing CommonJS support. This change eliminates
esmInteroperability
issues and aligns with modern JavaScript module standards.Updated CI Scripts:
Continuous Integration (CI) scripts have been updated to use the new
sf
CLI format to ensure smooth automation and testing processes.Updated Contribution Guide:
The Contributing Guide has been updated to reflect changes to the new structure and tools. New contributors can easily adapt to the latest development workflows and toolbelt.
Dropped Backward Compatibility with
sfdx/cli
:There is no backward compatibility with
sfdx/cli
as it is now deprecated. Users must transition tosalesforce/cli
.Migrated Back to npm:
The plugin now uses npm as the default package manager, streamlining dependency management and build processes.
These changes ensure that
sfdx-git-delta
remains aligned with the latest Salesforce CLI guidelines, offering a more efficient, modern, and user-friendly experience.Does this close any currently open issues?
closes #619
closes #906
closes #415
closes #924
closes #936