Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prune layoutAssignments, loginHours and loginIpRanges #954

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Nov 30, 2024

Explain your changes


Implement layoutAssignments, loginHours and loginIpRanges pruning algorithm.

For layoutAssignments the implementation outputs the previous list and new list difference based on object comparison

For loginHours and loginIpRanges the implementation outputs the new list only when the previous list and the new list are different.

Does this close any currently open issues?


closes #953
closes #948

@scolladon
Copy link
Owner Author

Hi @gvivo & @Joselulr90 !

Could you test on your side and help us validate this PR please ?
You can follow those steps to easily do it on your side

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4cf1a7d) to head (f35b52d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #954   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1030      1018   -12     
  Branches       104       104           
=========================================
- Hits          1030      1018   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the feat/improve-unidentifiable-submetadata-filtering branch from fa7b56b to ccea764 Compare December 1, 2024 18:51
@scolladon scolladon force-pushed the feat/improve-unidentifiable-submetadata-filtering branch from ccea764 to a8a6068 Compare December 1, 2024 18:56
mehdicherf
mehdicherf previously approved these changes Dec 2, 2024
@gvivo
Copy link

gvivo commented Dec 5, 2024

Hi @scolladon, tested on our end and looks fine so far

Copy link

codeclimate bot commented Dec 6, 2024

Code Climate has analyzed commit f35b52d and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 7d1804d into main Dec 6, 2024
20 of 22 checks passed
@scolladon scolladon deleted the feat/improve-unidentifiable-submetadata-filtering branch December 6, 2024 08:39
Copy link

github-actions bot commented Dec 9, 2024

Shipped in release v5.50.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.50.0

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behaviour with profiles Delta generation takes long time if delta consists meta.xml files
3 participants