-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prune layoutAssignments
, loginHours
and loginIpRanges
#954
feat: prune layoutAssignments
, loginHours
and loginIpRanges
#954
Conversation
Hi @gvivo & @Joselulr90 ! Could you test on your side and help us validate this PR please ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 1030 1018 -12
Branches 104 104
=========================================
- Hits 1030 1018 -12 ☔ View full report in Codecov by Sentry. |
fa7b56b
to
ccea764
Compare
ccea764
to
a8a6068
Compare
Hi @scolladon, tested on our end and looks fine so far |
Code Climate has analyzed commit f35b52d and detected 0 issues on this pull request. View more on Code Climate. |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.50.0 Happy incremental deployment! |
Explain your changes
Implement
layoutAssignments
,loginHours
andloginIpRanges
pruning algorithm.For
layoutAssignments
the implementation outputs the previous list and new list difference based on object comparisonFor
loginHours
andloginIpRanges
the implementation outputs the new list only when the previous list and the new list are different.Does this close any currently open issues?
closes #953
closes #948