build(deps): bump github.com/nunnatsa/ginkgolinter from 0.13.0 to 0.13.3 (golangci#3972)

Author: nunnatsa

.golangci.reference.yml

@@ -449,9 +449,9 @@ linters-settings:
     # Default: false
     suppress-async-assertion: true
 
-    # Suppress warning for ginkgo focus containers like FDescribe, FContext, FWhen or FIt
+    # Trigger warning for ginkgo focus containers like FDescribe, FContext, FWhen or FIt
     # Default: false
-    suppress-focus-container: true
+    forbid-focus-container: true
 
     # Don't trigger warnings for HaveLen(0)
     # Default: false

go.mod

@@ -77,7 +77,7 @@ require (
 	github.com/nakabonne/nestif v0.3.1
 	github.com/nishanths/exhaustive v0.11.0
 	github.com/nishanths/predeclared v0.2.2
-	github.com/nunnatsa/ginkgolinter v0.13.0
+	github.com/nunnatsa/ginkgolinter v0.13.3
 	github.com/polyfloyd/go-errorlint v1.4.3
 	github.com/quasilyte/go-ruleguard/dsl v0.3.22
 	github.com/ryancurrah/gomodguard v1.3.0

go.sum

@@ -396,7 +396,7 @@ type GinkgoLinterSettings struct {
 	SuppressErrAssertion     bool `mapstructure:"suppress-err-assertion"`
 	SuppressCompareAssertion bool `mapstructure:"suppress-compare-assertion"`
 	SuppressAsyncAssertion   bool `mapstructure:"suppress-async-assertion"`
-	SuppressFocusContainer   bool `mapstructure:"suppress-focus-container"`
+	ForbidFocusContainer     bool `mapstructure:"forbid-focus-container"`
 	AllowHaveLenZero         bool `mapstructure:"allow-havelen-zero"`
 }
 

pkg/config/linters_settings.go

@@ -19,7 +19,7 @@ func NewGinkgoLinter(cfg *config.GinkgoLinterSettings) *goanalysis.Linter {
 			"suppress-err-assertion":     cfg.SuppressErrAssertion,
 			"suppress-compare-assertion": cfg.SuppressCompareAssertion,
 			"suppress-async-assertion":   cfg.SuppressAsyncAssertion,
-			"suppress-focus-container":   cfg.SuppressFocusContainer,
+			"forbid-focus-container":     cfg.ForbidFocusContainer,
 			"allow-havelen-0":            cfg.AllowHaveLenZero,
 		}
 	}

pkg/golinters/ginkgolinter.go

@@ -1,3 +1,3 @@
 linters-settings:
   ginkgolinter:
-    suppress-focus-container: true
+    forbid-focus-container: true

test/testdata/ginkgolinter/configs/ginkgolinter_suppress_focused_containers.yml

@@ -78,10 +78,10 @@ func WrongEventuallyWithFunction() {
 	Eventually(slowInt()).Should(Equal(42)) // want "ginkgo-linter: use a function call in Eventually. This actually checks nothing, because Eventually receives the function returned value, instead of function itself, and this value is never changed; consider using .Eventually\\(slowInt\\)\\.Should\\(Equal\\(42\\)\\). instead"
 }
 
-var _ = Describe("Should warn for focused containers", func() {
-	FContext("should not allow FContext", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"Context\""
-		FWhen("should not allow FWhen", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"When\""
-			FIt("should not allow FIt", func() {}) // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"It\""
+var _ = FDescribe("Should warn for focused containers", func() {
+	FContext("should not allow FContext", func() {
+		FWhen("should not allow FWhen", func() {
+			FIt("should not allow FIt", func() {})
 		})
 	})
 })

test/testdata/ginkgolinter/ginkgolinter.go

@@ -79,10 +79,10 @@ func WrongEventuallyWithFunction_havelen0() {
 	Eventually(slowInt_havelen0()).Should(Equal(42)) // want "ginkgo-linter: use a function call in Eventually. This actually checks nothing, because Eventually receives the function returned value, instead of function itself, and this value is never changed; consider using .Eventually\\(slowInt_havelen0\\)\\.Should\\(Equal\\(42\\)\\). instead"
 }
 
-var _ = Describe("Should warn for focused containers", func() {
-	FContext("should not allow FContext", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"Context\""
-		FWhen("should not allow FWhen", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"When\""
-			FIt("should not allow FIt", func() {}) // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"It\""
+var _ = FDescribe("Should warn for focused containers", func() {
+	FContext("should not allow FContext", func() {
+		FWhen("should not allow FWhen", func() {
+			FIt("should not allow FIt", func() {})
 		})
 	})
 })

test/testdata/ginkgolinter/ginkgolinter_havelen0.go

@@ -80,10 +80,10 @@ func WrongEventuallyWithFunction_async() {
 	Eventually(slowInt_async()).Should(Equal(42)) // suppressed
 }
 
-var _ = Describe("Should warn for focused containers", func() {
-	FContext("should not allow FContext", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"Context\""
-		FWhen("should not allow FWhen", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"When\""
-			FIt("should not allow FIt", func() {}) // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"It\""
+var _ = FDescribe("Should warn for focused containers", func() {
+	FContext("should not allow FContext", func() {
+		FWhen("should not allow FWhen", func() {
+			FIt("should not allow FIt", func() {})
 		})
 	})
 })

test/testdata/ginkgolinter/ginkgolinter_suppress_async.go

@@ -80,10 +80,10 @@ func WrongEventuallyWithFunction_compare() {
 	Eventually(slowInt_compare()).Should(Equal(42)) // want "ginkgo-linter: use a function call in Eventually. This actually checks nothing, because Eventually receives the function returned value, instead of function itself, and this value is never changed; consider using .Eventually\\(slowInt_compare\\)\\.Should\\(Equal\\(42\\)\\). instead"
 }
 
-var _ = Describe("Should warn for focused containers", func() {
-	FContext("should not allow FContext", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"Context\""
-		FWhen("should not allow FWhen", func() { // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"When\""
-			FIt("should not allow FIt", func() {}) // want "ginkgo-linter: Focus container found. This is used only for local debug and should not be part of the actual source code, consider to replace with \"It\""
+var _ = FDescribe("Should warn for focused containers", func() {
+	FContext("should not allow FContext", func() {
+		FWhen("should not allow FWhen", func() {
+			FIt("should not allow FIt", func() {})
 		})
 	})
 })