Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Add a default in-cluster s3 provisioner #65

Closed
mathieu-benoit opened this issue Oct 18, 2024 · 0 comments · Fixed by #89
Closed

[feature request] Add a default in-cluster s3 provisioner #65

mathieu-benoit opened this issue Oct 18, 2024 · 0 comments · Fixed by #89
Assignees
@astromechza
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mathieu-benoit
Copy link
Contributor

Like we have for score-compose and for consistency ("I want to deploy the same Score file with both score-compose and score-k8s"), let's add a default in-cluster s3 provisioner like this one: https://github.com/score-spec/score-compose/blob/main/internal/command/default.provisioners.yaml#L197.

"in-cluster s3" because not real S3 in AWS, but an in-cluster minio container, like in score-compose.

Source file to update in this repo: https://github.com/score-spec/score-k8s/blob/main/internal/provisioners/default/zz-default.provisioners.yaml.
@mathieu-benoit mathieu-benoit added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 18, 2024
@astromechza astromechza self-assigned this Nov 21, 2024
@astromechza astromechza mentioned this issue Nov 21, 2024
Merged
@astromechza astromechza linked a pull request Nov 22, 2024 that will close this issue
Adding an s3 default provisioner based on minio #89
Merged
@astromechza astromechza mentioned this issue Nov 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in KubeCon EU 2025 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astromechza astromechza

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
KubeCon EU 2025
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding an s3 default provisioner based on minio score-spec/score-k8s
2 participants
@astromechza @mathieu-benoit