Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #10

Closed
lnicola opened this issue Oct 8, 2018 · 4 comments
Closed

Windows support #10

lnicola opened this issue Oct 8, 2018 · 4 comments

Comments

@lnicola
Copy link
Contributor

lnicola commented Oct 8, 2018

http-serve doesn't currently build on Windows because of some Unix-only APIs:

  • FileExt::read_at: Windows has a similar API that could be used instead -- the difference is that it moves the file cursor
  • MetadataExt::ino: there is a way to get the equivalent of a inode number on Windows, IIRC
@scottlamb
Copy link
Owner

I don't ever use Windows. Are you interested in adding this? and maybe setting up CI (I guess the cool kids use AppVeyor)?

@lnicola
Copy link
Contributor Author

lnicola commented Oct 11, 2018

I don't have any Windows box, and Windows doesn't work on my laptop (‽), so AppVeyor or a VM is the way to go.

I probably won't get a chance to try this in the near future, but I'll take it if it's not done by someone else by the time I'm free.

@lnicola
Copy link
Contributor Author

lnicola commented Oct 11, 2018

Hmm... https://blog.travis-ci.com/2018-10-11-windows-early-release

@scottlamb
Copy link
Owner

Wow, that's timely!

@lnicola lnicola mentioned this issue Oct 15, 2018
Merged
@scottlamb scottlamb mentioned this issue May 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lnicola @scottlamb