Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor notices into it's own component #82

Open
scottohara opened this issue Oct 15, 2018 · 0 comments
Open

Refactor notices into it's own component #82

scottohara opened this issue Oct 15, 2018 · 0 comments

Comments

@scottohara
Copy link
Owner

Currently the ApplicationController includes a bunch of functionality relating to notices, e.g.

  • noticeStack property (that holds the set of all current notifications)
  • showNotice() (shows a notice)
  • hideNotice() (hides a notice)
  • noticeHidden() (callback when a user acknowledges a notice)
  • noticesMoved() (manages the height of the notices container)

These could/should be moved out into a dedicated service/component for creating/tracking/showing/acknowledging notices; which would simplify the ApplicationController and allow it to focus on it's main job of managing the view stack (pushing/popping views).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant