Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS out of the box #290

Open
friedbrice opened this issue Nov 20, 2022 · 3 comments
Open

Support TLS out of the box #290

friedbrice opened this issue Nov 20, 2022 · 3 comments

Comments

@friedbrice
Copy link
Member

Is there a reason that TLS is shunted off to its own package and isn't supported out of the box?

@fumieval
Copy link
Collaborator

FWIW I haven't felt a desperate need because it's just a matter of calling warp-tls on top of scottyApp, and in most cases handling TLS is a reverse proxy's responsibility. However, I don't strongly object to adding a function that launch a server with TLS

@friedbrice
Copy link
Member Author

in most cases handling TLS is a reverse proxy's responsibility

This is a compelling point to me, yeah.

it's just a matter of calling warp-tls on top of scottyApp

This is a less-compelling point to me, since I typically think that Scotty users shouldn't have to know all that much about Warp, that Scotty should be taking care of that for them. I'm of the opinion that users shouldn't have to add warp as an explicit dependency in order to use the fully functionality that Scotty offers.

@fumieval
Copy link
Collaborator

Indeed, given that scotty supports WAI middlewares via the middleware function, perhaps there should be a function to enable TLS in the same vein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants