-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link formation should consider cases for string literal with spaces and encode them #58
Comments
@jrcastillo the result makes sense as we aren't doing any URL encoding. That said, an @ShadowManu @chamini2 can either of you think of a good reason to add extra cycles to URL encode? I personally cannot at this moment. |
Yes, we are using a primary key of bank module as the id which is a text. |
Well, the returned url should be escaped. It doesn't seem like a hard fix. |
True - simple, trivial fix. @jrcastillo, we'll add this as an enhancement. If you'd like to submit a PR, we'd be grateful! |
I've encountered an issue when the links for a json object are created. The code I'm generating forms a json object with a value of:
after passing this object through the mapper the expected link to be created should be encoded for urls like this:
instead it is being created this way
Is it the expected behavior ?
The text was updated successfully, but these errors were encountered: