Add a step to the CI build that fails on warnings in the functional tests (doesn't fail the build)

Author: eyalroth

.github/workflows/gradle.yml

@@ -11,6 +11,13 @@ on:
 
 jobs:
   build:
+    strategy:
+      matrix:
+        include:
+          - additional-check-args: ''
+            continue-on-error: false
+          - additional-check-args: '--warning-mode=fail -PfailOnWarning'
+            continue-on-error: true
 
     runs-on: ubuntu-latest
 
@@ -24,4 +31,5 @@ jobs:
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
     - name: Build with Gradle
-      run: ./gradlew --info --stacktrace check
+      run: ./gradlew --info --stacktrace check ${{ matrix.additional-check-args }}
+      continue-on-error: ${{ matrix.continue-on-error }}

build.gradle

@@ -104,6 +104,8 @@ task functionalTest(type: Test) {
         showStandardStreams = System.env.CI == 'true'
     }
 
+    systemProperty 'failOnWarning', project.hasProperty('failOnWarning')
+
     mustRunAfter crossScalaVersionTest
 }
 check.dependsOn functionalTest
@@ -206,4 +208,4 @@ idea.project.settings {
     taskTriggers {
         beforeBuild fixIdeaPluginClasspath, pluginUnderTestMetadata
     }
-}
+}

src/functionalTest/java/org/scoverage/ScoverageFunctionalTest.java

@@ -127,7 +127,11 @@ private void configureArguments(String... arguments) {
         fullArguments.add("-PjunitVersion=5.3.2");
         fullArguments.add("-PjunitPlatformVersion=1.3.2");
         fullArguments.add("-PscalatestVersion=3.0.8");
-        fullArguments.add("--warning-mode=all");
+        if (Boolean.parseBoolean(System.getProperty("failOnWarning"))) {
+            fullArguments.add("--warning-mode=fail");
+        } else {
+            fullArguments.add("--warning-mode=all");
+        }
         fullArguments.addAll(Arrays.asList(arguments));
 
         runner.withArguments(fullArguments);