Skip to content

Commit 20c9c75

Browse files
rockjamgslowikowski
authored andcommitted
add sbt 1.0.0-RC3 support, fixes #216 (#229)
* upgrade sbt version to 0.13.16; use sbt 0.13.16 and 1.0.0-RC3 as sbt cross build versions * run tests for both versions of sbt on CI * fix scalajs-library artifact detection * Upgrade scalajs plugin version
1 parent 81bba88 commit 20c9c75

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
language: scala
22

3-
script: sbt ++$TRAVIS_SCALA_VERSION scripted
3+
script: sbt ^scripted
44

55
scala:
66
- "2.10.6"

build.sbt

+2
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,5 @@ pomExtra := {
5555
</developer>
5656
</developers>
5757
}
58+
59+
crossSbtVersions := Vector("0.13.16", "1.0.0-RC3")

project/build.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=0.13.13
1+
sbt.version=0.13.16

src/main/scala/scoverage/ScoverageSbtPlugin.scala

+4-3
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,9 @@ object ScoverageSbtPlugin extends AutoPlugin {
6868

6969
private lazy val scalacSettings = Seq(
7070
scalacOptions in(Compile, compile) ++= {
71+
val updateReport = update.value
7172
if (coverageEnabled.value) {
72-
val scoverageDeps: Seq[File] = update.value matching configurationFilter(ScoveragePluginConfig.name)
73+
val scoverageDeps: Seq[File] = updateReport matching configurationFilter(ScoveragePluginConfig.name)
7374
val pluginPath: File = scoverageDeps.find(_.getAbsolutePath.contains(ScalacPluginArtifact)) match {
7475
case None => throw new Exception(s"Fatal: $ScalacPluginArtifact not in libraryDependencies")
7576
case Some(pluginPath) => pluginPath
@@ -94,8 +95,8 @@ object ScoverageSbtPlugin extends AutoPlugin {
9495

9596
// returns "_sjs$sjsVersion" for Scala.js projects or "" otherwise
9697
private def optionalScalaJsSuffix(deps: Seq[ModuleID]): String = {
97-
val sjsClassifier = deps.collectFirst{
98-
case ModuleID("org.scala-js", "scalajs-library", v, _, _, _, _, _, _, _, _) => v
98+
val sjsClassifier = deps.collectFirst {
99+
case moduleId if moduleId.organization == "org.scala-js" && moduleId.name == "scalajs-library" => moduleId.revision
99100
}.map(_.take(3)).map(sjsVersion => "_sjs" + sjsVersion)
100101

101102
sjsClassifier getOrElse ""

src/sbt-test/scoverage/preserve-set/build.sbt

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ libraryDependencies += "org.specs2" %% "specs2" % "2.3.13" % "test"
1111
val checkScalaVersion = inputKey[Unit]("Input task to compare the value of scalaVersion setting with a given input.")
1212
checkScalaVersion := {
1313
val arg: String = (Space ~> StringBasic).parsed
14-
if (scalaVersion.value != arg) error(s"scalaVersion [${scalaVersion.value}] not equal to expected [$arg]")
14+
if (scalaVersion.value != arg) sys.error(s"scalaVersion [${scalaVersion.value}] not equal to expected [$arg]")
1515
()
1616
}
1717

1818
val checkScoverageEnabled = inputKey[Unit]("Input task to compare the value of coverageEnabled setting with a given input.")
1919
checkScoverageEnabled := {
2020
val arg: String = (Space ~> StringBasic).parsed
21-
if (coverageEnabled.value.toString != arg) error(s"coverageEnabled [${coverageEnabled.value}] not equal to expected [$arg]")
21+
if (coverageEnabled.value.toString != arg) sys.error(s"coverageEnabled [${coverageEnabled.value}] not equal to expected [$arg]")
2222
()
2323
}
2424

src/sbt-test/scoverage/scalajs/project/plugins.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ resolvers ++= {
1313
Seq.empty
1414
}
1515

16-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.13")
16+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")

0 commit comments

Comments
 (0)