Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload configuration file without restart (i.e. via SIGHUP) #519

Closed
jpmckinney opened this issue Jul 17, 2024 · 1 comment
Closed

Reload configuration file without restart (i.e. via SIGHUP) #519

jpmckinney opened this issue Jul 17, 2024 · 1 comment

Comments

@jpmckinney
Copy link
Contributor

First mentioned in incomplete PR #186

@jpmckinney
Copy link
Contributor Author

jpmckinney commented Jul 19, 2024

Not quite sure what the plan was for #186. The Application instantiates a bunch of classes, including the Launcher which tracks the running processes in memory in a dict. The main reason I wouldn't want to restart Scrapyd is to avoid losing track of those processes – if I can restart Scrapyd while keeping track of processes #521, I don't really need reloads. Seeing as the configuration file can change things like the bind address, I don't see a way to reload that doesn't basically restart the app... So, closing as there doesn’t seem to be an advantage to reloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant