Do not use std::chars_format

adazem009 · adazem009 · commit 24e306767e35 · 2024-09-17T14:06:44.000+02:00
* use the overload with base parameter instead of std::chars_format::hex which is not fully supported on some compilers
diff --git a/src/scratch/value_functions_p.h b/src/scratch/value_functions_p.h
@@ -144,7 +144,7 @@ extern "C"
         return (str1.compare(str2) == 0);
     }
 
-    inline double value_hexToDec(const char *s, int n, bool *ok)
+    inline long value_hexToDec(const char *s, int n, bool *ok)
     {
         if (ok)
             *ok = false;
@@ -159,8 +159,8 @@ extern "C"
             p++;
         }
 
-        double result = 0;
-        auto [ptr, ec] = std::from_chars(s, s + n, result, std::chars_format::hex);
+        long result = 0;
+        auto [ptr, ec] = std::from_chars(s, s + n, result, 16);
 
         if (ec == std::errc{} && ptr == s + n) {
             if (ok)

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ extern "C"`
`144`	`144`	`return (str1.compare(str2) == 0);`
`145`	`145`	`}`
`146`	`146`
`147`		`- inline double value_hexToDec(const char s, int n, bool ok)`
	`147`	`+ inline long value_hexToDec(const char s, int n, bool ok)`
`148`	`148`	`{`
`149`	`149`	`if (ok)`
`150`	`150`	`*ok = false;`
`@@ -159,8 +159,8 @@ extern "C"`
`159`	`159`	`p++;`
`160`	`160`	`}`
`161`	`161`
`162`		`- double result = 0;`
`163`		`- auto [ptr, ec] = std::from_chars(s, s + n, result, std::chars_format::hex);`
	`162`	`+ long result = 0;`
	`163`	`+ auto [ptr, ec] = std::from_chars(s, s + n, result, 16);`
`164`	`164`
`165`	`165`	`if (ec == std::errc{} && ptr == s + n) {`
`166`	`166`	`if (ok)`